Link *san_with_fuzzer.so with -ldl
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `*san_with_fuzzer.so` dynamic libraries include libFuzzer, which requires `libdl.so`. However, in `merge_libfuzzer_sanitizer.sh`, the libraries are not linked with `-ldl`, which means that they can only be preloaded into a binary that itself links in `libdl.so`. While `python` itself does this, shells might not, which can lead to errors when the preload is applied to e.g. a wrapper script that unpacks a packaged Python application and only then invokes `python` itself. This is fixed by linking `*san_with_fuzzer.so` with `-ldl`.
|
@IanPudney Could this change be included in a PyPI release? I'm currently working on adding Atheris to Bazel's |
|
That's in progress :) |
|
The reason for the delay: the Mac build is built manually, and I recently got a new machine, which means rebuilding Clang and its dependencies. Yay. |
|
Linux and source-code builds are pushed. Mac incoming soon. |
|
Mac is done. |
TheShiftedBit
added a commit
that referenced
this pull request
Jul 28, 2021
Link `*san_with_fuzzer.so` with `-ldl`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
*san_with_fuzzer.sodynamic libraries include libFuzzer, which requireslibdl.so. However, inmerge_libfuzzer_sanitizer.sh, the libraries are not linked with-ldl, which means that they can only be preloaded into a binary that itself links inlibdl.so. Whilepythonitself does this, shells might not, which can lead to errors when the preload is applied to e.g. a wrapper script that unpacks a packaged Python application and only then invokespythonitself.This is fixed by linking
*san_with_fuzzer.sowith-ldl.