Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parse_image_size #1025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smedegaard
Copy link

parse_image_size() in efficientdet/utils.py swaps height and width of the image when you give a string as argument.

This PR fixes that and makes it possible to pass a dict.

Explicit is better than implicit.

@google-cla
Copy link

google-cla bot commented Jun 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 11, 2021
@smedegaard
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jun 11, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@smedegaard
Copy link
Author

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Jun 11, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@smedegaard smedegaard force-pushed the parse_image_size_bug branch from 1e8841e to e5dd6a5 Compare June 11, 2021 15:22
@google-cla google-cla bot added cla: yes CLA has been signed. and removed cla: no labels Jun 11, 2021
@smedegaard smedegaard closed this Jun 11, 2021
@smedegaard smedegaard reopened this Jun 11, 2021
@smedegaard
Copy link
Author

@googlebot I fixed it.

brothertook added a commit to brothertook/automl that referenced this pull request Jul 2, 2021
brothertook added a commit to brothertook/automl that referenced this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant