Fix the VariantAnimationTimelineTest #1945
Assignees
Comments
timothyfroehlich
added a commit
that referenced
this issue
Dec 26, 2024
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies. Task to fix it is #1945
timothyfroehlich
added a commit
that referenced
this issue
Dec 26, 2024
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies. Task to fix it is #1945
timothyfroehlich
added a commit
that referenced
this issue
Dec 26, 2024
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies. Task to fix it is #1945
timothyfroehlich
added a commit
that referenced
this issue
Dec 26, 2024
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies. Task to fix it is #1945
timothyfroehlich
added a commit
that referenced
this issue
Dec 26, 2024
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies. Task to fix it is #1945
timothyfroehlich
added a commit
that referenced
this issue
Dec 26, 2024
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies. Task to fix it is #1945
timothyfroehlich
added a commit
that referenced
this issue
Dec 26, 2024
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies. Task to fix it is #1945
timothyfroehlich
added a commit
that referenced
this issue
Dec 26, 2024
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies. Task to fix it is #1945
timothyfroehlich
added a commit
that referenced
this issue
Jan 9, 2025
This change modifies the test setup for `DocSerializationTest` to improve its robustness and coverage. - Removes `showStandardStreams = true` from the roborazzi gradle config, to quiet down the amount of console spam - Adds the validation assets directory to the test resources for the common module. - Replaces the single `loadSaveLoadHelloWorld` test with a parameterized test `LoadSaveLoadAllDocsTest` to make it easier to see which docs aren't passing - Removes the `VariantAnimationTimelineTestDoc_vJRf4zxY4QX4zzSSUd1nJ5.dcf` file. The test is disabled right now ( #1945 ) so the dcf wasn't being updated and was failing to decode.
timothyfroehlich
added a commit
that referenced
this issue
Jan 9, 2025
This change modifies the test setup for `DocSerializationTest` to improve its robustness and coverage. - Removes `showStandardStreams = true` from the roborazzi gradle config, to quiet down the amount of console spam - Adds the validation assets directory to the test resources for the common module. - Replaces the single `loadSaveLoadHelloWorld` test with a parameterized test `LoadSaveLoadAllDocsTest` to make it easier to see which docs aren't passing - Removes the `VariantAnimationTimelineTestDoc_vJRf4zxY4QX4zzSSUd1nJ5.dcf` file. The test is disabled right now ( #1945 ) so the dcf wasn't being updated and was failing to decode.
timothyfroehlich
added a commit
that referenced
this issue
Jan 10, 2025
This change modifies the test setup for `DocSerializationTest` to improve its robustness and coverage. - Removes `showStandardStreams = true` from the roborazzi gradle config, to quiet down the amount of console spam - Adds the validation assets directory to the test resources for the common module. - Replaces the single `loadSaveLoadHelloWorld` test with a parameterized test `LoadSaveLoadAllDocsTest` to make it easier to see which docs aren't passing - Removes the `VariantAnimationTimelineTestDoc_vJRf4zxY4QX4zzSSUd1nJ5.dcf` file. The test is disabled right now ( #1945 ) so the dcf wasn't being updated and was failing to decode.
timothyfroehlich
added a commit
that referenced
this issue
Jan 10, 2025
This change modifies the test setup for `DocSerializationTest` to improve its robustness and coverage. - Removes `showStandardStreams = true` from the roborazzi gradle config, to quiet down the amount of console spam - Adds the validation assets directory to the test resources for the common module. - Replaces the single `loadSaveLoadHelloWorld` test with a parameterized test `LoadSaveLoadAllDocsTest` to make it easier to see which docs aren't passing - Removes the `VariantAnimationTimelineTestDoc_vJRf4zxY4QX4zzSSUd1nJ5.dcf` file. The test is disabled right now ( #1945 ) so the dcf wasn't being updated and was failing to decode.
timothyfroehlich
added a commit
that referenced
this issue
Jan 10, 2025
This change modifies the test setup for `DocSerializationTest` to improve its robustness and coverage. - Removes `showStandardStreams = true` from the roborazzi gradle config, to quiet down the amount of console spam - Adds the validation assets directory to the test resources for the common module. - Replaces the single `loadSaveLoadHelloWorld` test with a parameterized test `LoadSaveLoadAllDocsTest` to make it easier to see which docs aren't passing - Removes the `VariantAnimationTimelineTestDoc_vJRf4zxY4QX4zzSSUd1nJ5.dcf` file. The test is disabled right now ( #1945 ) so the dcf wasn't being updated and was failing to decode.
timothyfroehlich
added a commit
that referenced
this issue
Jan 10, 2025
<!-- start git-machete generated --> # Based on PR #1886 ## Chain of upstream PRs as of 2025-01-09 * PR #1886: `main` ← `feature/protoconv` * **PR #1964 (THIS ONE)**: `feature/protoconv` ← `wb/froeht/improve-docserializationtest` <!-- end git-machete generated --> This change modifies the test setup for `DocSerializationTest` to improve its robustness and coverage. - Removes `showStandardStreams = true` from the roborazzi gradle config, to quiet down the amount of console spam - Adds the validation assets directory to the test resources for the common module. - Replaces the single `loadSaveLoadHelloWorld` test with a parameterized test `LoadSaveLoadAllDocsTest` to make it easier to see which docs aren't passing - Removes the `VariantAnimationTimelineTestDoc_vJRf4zxY4QX4zzSSUd1nJ5.dcf` file. The test is disabled right now ( #1945 ) so the dcf wasn't being updated and was failing to decode.
rylin8
added a commit
that referenced
this issue
Jan 10, 2025
Fixes #1945: Add functions to VariantTransitionContext that allow access to the view names.
rylin8
added a commit
that referenced
this issue
Jan 13, 2025
Fixes #1945: Add functions to VariantTransitionContext that allow access to the view names.
rylin8
added a commit
that referenced
this issue
Jan 13, 2025
Fixes #1945: Add functions to VariantTransitionContext that allow access to the view names.
rylin8
added a commit
that referenced
this issue
Jan 13, 2025
Fixes #1945: Add functions to VariantTransitionContext that allow access to the view names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies.
The text was updated successfully, but these errors were encountered: