-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable the VariantAnimationTimelineTest. #1946
Temporarily disable the VariantAnimationTimelineTest. #1946
Conversation
2c9e656
to
bd572fa
Compare
What part of DesignDoc does it try to access? Please use multi-line comments /* */ so we don't see a line changed in the history of the file for every single line. It makes blame harder to use. |
a44231a
to
c823e91
Compare
bd572fa
to
bd9e855
Compare
Something related to line 82 of VariantAnimationTimelineTest:
Good call on using multi-line comments. |
bd9e855
to
8900fa6
Compare
8900fa6
to
c6f1a0c
Compare
I'm fine fixing this test later, but I don't really get what the issue is with accessing part of the design doc. It just uses the context passed into the custom animation function to see what the source and destination node names are, and that's passed in from DesignCompose in the animation code. |
c823e91
to
2467781
Compare
c6f1a0c
to
2467781
Compare
<!-- start git-machete generated --> # Based on PR #1947 ## Chain of upstream PRs as of 2024-12-26 * PR #1886: `main` ← `feature/protoconv` * PR #1941: `feature/protoconv` ← `wb/froeht/protolize-dcf` * PR #1943: `wb/froeht/protolize-dcf` ← `wb/froeht/delete-proto-utils` * PR #1946: `wb/froeht/delete-proto-utils` ← `wb/froeht/temp-disable-variant-animation-test` * PR #1947: `wb/froeht/temp-disable-variant-animation-test` ← `wb/froeht/remove-serde-from-kotlin` * **PR #1948 (THIS ONE)**: `wb/froeht/remove-serde-from-kotlin` ← `wb/froeht/resolve-runtime-exceptions` <!-- end git-machete generated --> Protobuf maps are immutable and need to be modified by copying them.
Based on PR #1943
Chain of upstream PRs as of 2024-12-26
PR [PROTOCONV] Convert the Kotlin code to Proto #1886:
main
←feature/protoconv
PR Convert the encoded DCF and ServerFigmaDocs to Proto #1941:
feature/protoconv
←wb/froeht/protolize-dcf
PR Delete the no-longer-necessary proto utils #1943:
wb/froeht/protolize-dcf
←wb/froeht/delete-proto-utils
wb/froeht/delete-proto-utils
←wb/froeht/temp-disable-variant-animation-test
It tries to access parts of the DesignDoc that aren't meant to be accessed, and fails to compile because Validation does not have the protobuf libraries as a dependency. We don't want to expose the Protobuf API, because this can lead to compilation problems when another library uses a different version of the Protobuf library. We'll need to change the test to resolve the compilation error without modifying it's Gradle dependencies.
Task to fix it is #1945