Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve various warnings in the code #1949

Merged

Conversation

timothyfroehlich
Copy link
Member

@timothyfroehlich timothyfroehlich commented Dec 26, 2024

This should help us track down some of the bugs we're having with the proto conversion.

@timothyfroehlich timothyfroehlich self-assigned this Dec 26, 2024
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/resolve-runtime-exceptions branch from 60bfc67 to bdf479b Compare December 26, 2024 21:00
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/resolve-various-warning branch 2 times, most recently from 7f1d0e1 to 6d9ea9e Compare December 26, 2024 21:02
@timothyfroehlich timothyfroehlich marked this pull request as ready for review December 26, 2024 21:02
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/resolve-various-warning branch from 6d9ea9e to f0c55a3 Compare December 26, 2024 21:06
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/resolve-runtime-exceptions branch 3 times, most recently from 930c162 to 694a897 Compare December 26, 2024 22:18
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/resolve-various-warning branch from f0c55a3 to 35c8b5e Compare December 26, 2024 22:48
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/resolve-runtime-exceptions branch from 694a897 to 3cb16e1 Compare December 26, 2024 22:50
Base automatically changed from wb/froeht/resolve-runtime-exceptions to feature/protoconv December 26, 2024 22:51
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/resolve-various-warning branch 4 times, most recently from fde2c87 to e985eed Compare December 26, 2024 23:17
This should help us track down some of the bugs we're having with the proto conversion.

# Conflicts:
#	designcompose/src/main/java/com/android/designcompose/squoosh/SquooshText.kt
#	designcompose/src/main/java/com/android/designcompose/squoosh/SquooshTreeBuilder.kt
#	integration-tests/validation/src/main/java/com/android/designcompose/testapp/validation/examples/AllExamples.kt
#	integration-tests/validation/src/main/java/com/android/designcompose/testapp/validation/examples/VariantAnimationTimelineTest.kt
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/resolve-various-warning branch from e985eed to e5f6cd2 Compare December 27, 2024 16:25
@timothyfroehlich timothyfroehlich merged commit f0643dc into feature/protoconv Dec 27, 2024
18 of 22 checks passed
@timothyfroehlich timothyfroehlich deleted the wb/froeht/resolve-various-warning branch December 27, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants