Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #1836

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update documentation #1836

merged 1 commit into from
Dec 4, 2024

Conversation

rylin8
Copy link
Collaborator

@rylin8 rylin8 commented Dec 4, 2024

Fixes #1835.

Update docs for dcf_info
Update docs on testing nodes with squoosh
Delete some obsolete stuff

Copy link

github-actions bot commented Dec 4, 2024

Snapshot diff report vs base branch: main
Last updated: Wed Dec 4 11:35:11 PST 2024, Sha: ee6d2b1
No differences detected

@rylin8 rylin8 marked this pull request as ready for review December 4, 2024 00:39
docs/_docs/tips.md Outdated Show resolved Hide resolved
Fixes #1835.

Update docs for dcf_info
Update docs on testing nodes with squoosh
Delete some obsolete stuff
@yiqunw700
Copy link
Contributor

Looks good to me.
Regarding the test tips for squoosh interaction, squoosh also creates child composables for nodes with interactions if I recall correctly. If that is the case, I am wondering if you are considering adding some kind of tags or content descriptions to those child composables in squoosh so we will be able to test interactions without doing component/content replacement.

@rylin8
Copy link
Collaborator Author

rylin8 commented Dec 4, 2024

Looks good to me. Regarding the test tips for squoosh interaction, squoosh also creates child composables for nodes with interactions if I recall correctly. If that is the case, I am wondering if you are considering adding some kind of tags or content descriptions to those child composables in squoosh so we will be able to test interactions without doing component/content replacement.

Hoping to figure something out so we don't need component replacements -- ticket to do that is #1834. If you have ideas please add to the ticket!

@rylin8 rylin8 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 68a6bbf Dec 4, 2024
24 checks passed
@rylin8 rylin8 deleted the wb/rylin/docs branch December 4, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation
2 participants