Initial Roborazzi support #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyfroehlich
changed the base branch from
main
to
wb/froeht/test-all-validation
integration-tests/validation/src/testDebug/roborazzi/RenderAllExamples/Battleship.png
Outdated
Show resolved
Hide resolved
integration-tests/validation/src/testDebug/roborazzi/RenderAllExamples/Grid-Layout.png
Outdated
Show resolved
Hide resolved
integration-tests/validation/src/testDebug/roborazzi/RenderAllExamples/Item-Spacing.png
Outdated
Show resolved
Hide resolved
timothyfroehlich
added
Type: New Feature
timothyfroehlich
force-pushed
the
wb/froeht/roborazzi
branch
2 times, most recently
from
cfa7dae to
82cceca
Compare
timothyfroehlich
changed the base branch from
wb/froeht/test-all-validation
to
wb/froeht/designcompose-test-fixture
timothyfroehlich
force-pushed
the
wb/froeht/roborazzi
branch
from
49e5f76 to
d32edc9
Compare
Base automatically changed from
wb/froeht/designcompose-test-fixture
to
main
September 14, 2023 20:55
|
This is stalled for a bit, I'm running into a crash while trying to do screenshot tests of the DesignSwitcher. I've asked for help here: takahirom/roborazzi#164 |
This adds a basic Roborazzi test to HelloWorld and includes documentation on it.
timothyfroehlich
force-pushed
the
wb/froeht/roborazzi
branch
from
e57308e to
00fc12e
Compare
takahirom
approved these changes
Sep 21, 2023
rylin8
reviewed
Sep 28, 2023
rylin8
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic Roborazzi test to HelloWorld and includes documentation on it. Subsequent PRs will add roborazzi tests for Validation and the DesignSwitcher.
Please review the implementation and let me know if there's any questions. Once approved I'll update the Validation draft with the changes and finish the DesignSwitcher Roborazzi tests.
See the Readme and new docs for instructions.