-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #844: Add documentation for component replacement #874
Conversation
Snapshot diff report vs base branch: main |
a10f7b3
to
73f8a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Component replacement deserves more of a write-up with a more clear use case and images of the Figma File and what the rendered result would be, but we can get away with what we have here.
Generally, the documentation has gotten garbled in all of the transitions from when we originally wrote it. We need a bit more of a rewrite, and as I mentioned in the comments, it should start more simply, without mentioning the ComponentReplacementContext. Describe the CRC and why you'd need it after the simple example.
@Gurupreet Could you take a look at this as well? |
73f8a09
to
d34aad8
Compare
Explain what is in the updated ComponentReplacementContext class and how to use with non-DesignCompose replacement composables.
d34aad8
to
3fe17de
Compare
Explain what is in the updated ComponentReplacementContext class and how to use with non-DesignCompose replacement composables.