Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Squoosh to be enabled at runtime, add DesignDocSettings #955

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

timothyfroehlich
Copy link
Member

This is implemented as a class that can be applied to a DesignCompose composable via a localComposition.

@timothyfroehlich timothyfroehlich self-assigned this Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Snapshot diff report vs base branch: main
Last updated: Thu Apr 4 14:38:27 PDT 2024, Sha: f7b5d88
No differences detected

Copy link
Member Author

@timothyfroehlich timothyfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First step for #915. Upon approval I'll continue with the other changes that were requested.

@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/DesignDocSettings branch from 5d29157 to 9d5bd0c Compare April 3, 2024 17:36
@timothyfroehlich timothyfroehlich force-pushed the wb/froeht/DesignDocSettings branch from 9d5bd0c to 9205a62 Compare April 3, 2024 17:45
Base automatically changed from wb/froeht/squooshDocRenderStatus to main April 4, 2024 17:24
@timothyfroehlich timothyfroehlich added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 9dd5d81 Apr 4, 2024
25 checks passed
@timothyfroehlich timothyfroehlich deleted the wb/froeht/DesignDocSettings branch April 4, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor DesignDocOverride into more generic DesignSettings, and make Squoosh runtime enable-able
3 participants