-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Squoosh to be enabled at runtime, add DesignDocSettings #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshot diff report vs base branch: main |
timothyfroehlich
commented
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First step for #915. Upon approval I'll continue with the other changes that were requested.
timothyfroehlich
force-pushed
the
wb/froeht/DesignDocSettings
branch
from
April 3, 2024 17:36
5d29157
to
9d5bd0c
Compare
timothyfroehlich
force-pushed
the
wb/froeht/DesignDocSettings
branch
from
April 3, 2024 17:45
9d5bd0c
to
9205a62
Compare
iamralpht
reviewed
Apr 3, 2024
designcompose/src/main/java/com/android/designcompose/DesignDocSettings.kt
Outdated
Show resolved
Hide resolved
iamralpht
reviewed
Apr 4, 2024
...lidation/src/main/java/com/android/designcompose/testapp/validation/examples/HelloSquoosh.kt
Show resolved
Hide resolved
iamralpht
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented as a class that can be applied to a DesignCompose composable via a localComposition.