fix: resolve editable installation issue for python package #1989
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like a linter issue that needs resolving @senyai |
Before this `pip install -e .` produced ` error: [Errno 2] No such file or directory: '/tmp/tmpi02jtn4q.build-lib/google_benchmark/_benchmark.pyi'`
senyai
force-pushed
the
senyai-pip-install
branch
from
79b4cf3 to
00af678
Compare
dmah42
approved these changes
May 21, 2025
nicholasjng
reviewed
May 21, 2025
| libdir = Path(self.build_lib) / pkgname | ||
| else: | ||
| build_py = self.get_finalized_command("build_py") | ||
| libdir = build_py.get_package_dir(pkgname) |
There was a problem hiding this comment.
Have you tested with self.inplace? This looks wrong, since get_package_dir returns a str, which would make the path concatenation in shutil.copyfile below fail, see https://github.com/pypa/setuptools/blob/main/setuptools/command/build_py.py#L275.
At minimum, I think this should be a Path(build_py.get_package_dir(pkgname)).
There was a problem hiding this comment.
Yes, I tested it and it works fp in libdir / fp is Path, and 'str / Path' results in Path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this
pip install -e .producederror: [Errno 2] No such file or directory: '/tmp/tmpi02jtn4q.build-lib/google_benchmark/_benchmark.pyi'Second try of #1987. I hope code makes more sense now. Yes,
_benchmark.pyi,_benchmark.soandpy.typedgo to the source tree, but this is how it is supposed to work.