Skip to content

Commit

Permalink
fix: Call blocks handle both manual disabling and disabled defs (#2334)
Browse files Browse the repository at this point in the history
* Update blockly dependency from 11.0.0-beta.7 to 11.0.0-beta.9

* Disallow reenabling a call block with a disabled def.
  • Loading branch information
johnnesky authored May 3, 2024
1 parent c10b34f commit 5eade55
Show file tree
Hide file tree
Showing 83 changed files with 394 additions and 422 deletions.
16 changes: 8 additions & 8 deletions plugins/block-dynamic-connection/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions plugins/block-dynamic-connection/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@
"devDependencies": {
"@blockly/dev-scripts": "^3.1.1",
"@blockly/dev-tools": "^7.1.6",
"blockly": "^11.0.0-beta.7",
"blockly": "^11.0.0-beta.9",
"chai": "^4.2.0",
"mocha": "^10.2.0",
"typescript": "^5.2.2"
},
"peerDependencies": {
"blockly": "^11.0.0-beta.7"
"blockly": "^11.0.0-beta.9"
},
"publishConfig": {
"access": "public",
Expand Down
16 changes: 8 additions & 8 deletions plugins/block-plus-minus/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions plugins/block-plus-minus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@
"devDependencies": {
"@blockly/dev-scripts": "^3.1.1",
"@blockly/dev-tools": "^7.1.6",
"blockly": "^11.0.0-beta.7",
"blockly": "^11.0.0-beta.9",
"chai": "^4.2.0",
"mocha": "^10.2.0",
"sinon": "^9.0.1"
},
"peerDependencies": {
"blockly": "^11.0.0-beta.7"
"blockly": "^11.0.0-beta.9"
},
"publishConfig": {
"access": "public",
Expand Down
10 changes: 5 additions & 5 deletions plugins/block-shareable-procedures/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions plugins/block-shareable-procedures/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@
"devDependencies": {
"@blockly/dev-scripts": "^3.1.1",
"@blockly/dev-tools": "^7.1.6",
"blockly": "^11.0.0-beta.7",
"blockly": "^11.0.0-beta.9",
"chai": "^4.3.7",
"jsdom": "^16.4.0",
"jsdom-global": "^3.0.2",
"sinon": "^15.0.1",
"typescript": "^5.2.2"
},
"peerDependencies": {
"blockly": "^11.0.0-beta.7"
"blockly": "^11.0.0-beta.9"
},
"publishConfig": {
"access": "public",
Expand Down
16 changes: 7 additions & 9 deletions plugins/block-shareable-procedures/src/blocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ const procedureDefOnChangeMixin = {
e.blockId === this.id &&
e.element === 'disabled'
) {
this.getProcedureModel().setEnabled(!e.newValue);
this.getProcedureModel().setEnabled(this.isEnabled());
}
},
};
Expand Down Expand Up @@ -949,8 +949,6 @@ Blockly.Extensions.register(
);

const procedureCallerMutator = {
previousEnabledState_: true,

paramsFromSerializedState_: [],

/**
Expand Down Expand Up @@ -1053,6 +1051,8 @@ Blockly.Extensions.registerMutator(
procedureCallerMutator,
);

const PROCEDURE_MODEL_DISABLED_REASON = 'PROCEDURE_MODEL_DISABLED';

const procedureCallerUpdateShapeMixin = {
/**
* Renders the block for the first time based on the procedure model.
Expand Down Expand Up @@ -1094,12 +1094,10 @@ const procedureCallerUpdateShapeMixin = {
* model.
*/
updateEnabled_: function () {
if (!this.getProcedureModel().getEnabled()) {
this.previousEnabledState_ = this.isEnabled();
this.setEnabled(false);
} else {
this.setEnabled(this.previousEnabledState_);
}
this.setDisabledReason(
!this.getProcedureModel().getEnabled(),
PROCEDURE_MODEL_DISABLED_REASON,
);
},

/**
Expand Down
16 changes: 8 additions & 8 deletions plugins/block-test/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions plugins/block-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
],
"devDependencies": {
"@blockly/dev-scripts": "^3.1.1",
"blockly": "^11.0.0-beta.7"
"blockly": "^11.0.0-beta.9"
},
"peerDependencies": {
"blockly": "^11.0.0-beta.7"
"blockly": "^11.0.0-beta.9"
},
"publishConfig": {
"access": "public",
Expand Down
16 changes: 8 additions & 8 deletions plugins/content-highlight/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions plugins/content-highlight/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@
"devDependencies": {
"@blockly/dev-scripts": "^3.1.1",
"@blockly/dev-tools": "^7.1.6",
"blockly": "^11.0.0-beta.7",
"blockly": "^11.0.0-beta.9",
"typescript": "^5.2.2"
},
"peerDependencies": {
"blockly": "^11.0.0-beta.7"
"blockly": "^11.0.0-beta.9"
},
"publishConfig": {
"access": "public",
Expand Down
16 changes: 8 additions & 8 deletions plugins/continuous-toolbox/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions plugins/continuous-toolbox/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@
"devDependencies": {
"@blockly/dev-scripts": "^3.1.1",
"@blockly/dev-tools": "^7.1.6",
"blockly": "^11.0.0-beta.7"
"blockly": "^11.0.0-beta.9"
},
"peerDependencies": {
"blockly": "^11.0.0-beta.7"
"blockly": "^11.0.0-beta.9"
},
"publishConfig": {
"access": "public",
Expand Down
Loading

0 comments on commit 5eade55

Please sign in to comment.