feat: have backpack hide scrollbars when flyout opens (#1842)

* feat: have backpack hide scrollbars when flyout opens * fix: scrollbars may not exist * chore: add checks before settin visibility
google · Aug 21, 2023 · b5f6f0b · b5f6f0b
1 parent 230ba13
commit b5f6f0b
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/plugins/workspace-backpack/src/backpack.js b/plugins/workspace-backpack/src/backpack.js
@@ -681,6 +681,12 @@ export class Backpack extends Blockly.DragTarget {
     }
     const jsons = this.contents_.map((text) => JSON.parse(text));
     this.flyout_.show(jsons);
+    // TODO: We can remove the setVisible check when updating from ^10.0.0 to
+    //    ^11.
+    if (this.workspace_.scrollbar &&
+    /** @type {*} */ (this.workspace_.scrollbar).setVisible) {
+      /** @type {*} */ (this.workspace_.scrollbar).setVisible(false);
+    }
     Blockly.Events.fire(new BackpackOpen(true, this.workspace_.id));
   }
 
@@ -704,6 +710,12 @@ export class Backpack extends Blockly.DragTarget {
       return;
     }
     this.flyout_.hide();
+    // TODO: We can remove the setVisible check when updating from ^10.0.0 to
+    //    ^11.
+    if (this.workspace_.scrollbar &&
+    /** @type {*} */ (this.workspace_.scrollbar).setVisible) {
+      /** @type {*} */ (this.workspace_.scrollbar).setVisible(true);
+    }
     Blockly.Events.fire(new BackpackOpen(false, this.workspace_.id));
   }
 
@@ -942,5 +954,3 @@ class BackpackSerializer {
     backpack.empty();
   }
 }
-
-