fix: Focus region bug when primary workspace zoomed (#1851)

google · Aug 10, 2023 · e7c7d0d · e7c7d0d
1 parent c463a32
commit e7c7d0d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/plugins/workspace-minimap/src/focus_region.ts b/plugins/workspace-minimap/src/focus_region.ts
@@ -149,11 +149,16 @@ export class FocusRegion {
       const primaryMetrics = this.primaryWorkspace.getMetricsManager();
       const minimapMetrics = this.minimapWorkspace.getMetricsManager();
 
-      const primaryView = primaryMetrics.getViewMetrics();
-      const primaryContent = primaryMetrics.getContentMetrics();
+      const primaryView = primaryMetrics.getViewMetrics(true);
+      const primaryContent = primaryMetrics.getContentMetrics(true);
       const minimapContent = minimapMetrics.getContentMetrics();
       const minimapSvg = minimapMetrics.getSvgMetrics();
 
+      // Return if there is no content.
+      if (primaryContent.width === 0) {
+        return;
+      }
+
       // Get the workscape to pixel scale on the minimap.
       const scale = minimapContent.width /
         minimapMetrics.getContentMetrics(true).width;

diff --git a/plugins/workspace-minimap/src/minimap.ts b/plugins/workspace-minimap/src/minimap.ts
@@ -215,6 +215,7 @@ export class Minimap {
     private onClickUp(): void {
       if (this.onMouseMoveWrapper) {
         Blockly.browserEvents.unbind(this.onMouseMoveWrapper);
+        this.onMouseMoveWrapper = null;
       }
     }