Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update single-direction-scroll-demo xml to json #1769

Conversation

varshneydevansh
Copy link
Contributor

Issue

Category

Proposed Solution

  • Update the code in blockly-samples to use the JSON toolbox API.

Result

  • After testing, it's working the same way it did before with the XML.

image

@varshneydevansh varshneydevansh requested a review from a team as a code owner July 10, 2023 20:32
@varshneydevansh varshneydevansh requested review from BeksOmega and removed request for a team July 10, 2023 20:32
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for the fix =) This conversion LGTM!

With regard to the CI failure, could you do git commit --amend to fix your commit message? We have more detailed instructions here: https://developers.google.com/blockly/guides/contribute/get-started/commits#fixing_non-conventional_commits

Once CI passes I'll get this merged!

@varshneydevansh
Copy link
Contributor Author

I did try it at the night but forgot to do the push as it was late at night, so I went to sleep.

Doing it now.

image

@varshneydevansh varshneydevansh force-pushed the Update_single_direction_scroll_demo_JSON_1264 branch from 797b599 to b8b44ca Compare July 11, 2023 06:53
Copy link
Contributor Author

@varshneydevansh varshneydevansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed an empty line.

@varshneydevansh
Copy link
Contributor Author

@BeksOmega I was doing this issue #6280 and this issue was linked to it.

@BeksOmega BeksOmega merged commit 78be49e into google:master Jul 11, 2023
6 checks passed
@varshneydevansh varshneydevansh deleted the Update_single_direction_scroll_demo_JSON_1264 branch July 11, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants