Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package locks and misc dependencies #1777

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

maribethb
Copy link
Contributor

@maribethb maribethb commented Jul 13, 2023

  • Updates examples/blockly-vue version of eslint to satisfy some of its peer dependency issues
  • Updates workspace-minimap to use v7 of @blockly/dev-tools instead of v6. This was likely not updated because it was submitted after the major version bump to dev-tools, so it didn't get auto-bumped by lerna because it didn't exist yet. This can cause problems because lerna would be using the version from npm instead of locally linking it like everything else.
  • Updates versions of other plugins similar to above used inside examples to latest versions, then tested that those plugins run correctly still (this resolves peer dependency version issues with blockly)
  • Ran npm install at root and then cd examples && npm install to update all package-locks. Dependabot unfortunately messes up our package-locks and keeps adding back the local dependencies to the lockfiles.... see feat: add a workflow that cleans up after dependabot #1776

This should fix CI failures caused by inconsistent package-lock states causing npm ci to fail. I tested by running npm run clean:node and npm ci at root, then npx lerna clean --yes and npm ci in examples after committing these changes and it passed / no pending changes / no peer dependency issues

@maribethb maribethb requested a review from a team as a code owner July 13, 2023 23:52
@maribethb maribethb requested review from cpcallen and removed request for a team July 13, 2023 23:52
@maribethb
Copy link
Contributor Author

unnamed

Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing you outlined makes sense and these changes don't look crazy!

@maribethb maribethb merged commit 046db9f into google:master Jul 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants