Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option skip backpack serializer registration #1829

Conversation

johnnyoshika
Copy link
Contributor

Add option to skip backpack serializer registration.

Usage

new Backpack(workspace, {
  skipSerializerRegistration: true,
})

Tests

Tested with the following:

new Backpack(workspace) // Registers serializer
new Backpack(workspace, { skipSerializerRegistration: false}) // Registers serializer
new Backpack(workspace, { skipSerializerRegistration: true }) // Does not register serializer
new Backpack(workspace) // Registers serializer
new Backpack(workspace) // Does not register serializer, as it's already registered
new Backpack(workspace, { skipSerializerRegistration: true }) // Does not register serializer, but it also doesn't unregister serializer

Closes #1826

@johnnyoshika johnnyoshika requested a review from a team as a code owner July 27, 2023 19:18
@johnnyoshika johnnyoshika requested review from maribethb and removed request for a team July 27, 2023 19:18
Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for also updating the docs!

@maribethb maribethb merged commit c139845 into google:master Jul 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurable serializer behavior for backpack
2 participants