chore: Convert zoom-to-fit plugin to TypeScript. #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
reviewed
Aug 18, 2023
BeksOmega
approved these changes
Aug 18, 2023
gonfunko
added a commit
to gonfunko/blockly-samples
that referenced
this pull request
Aug 25, 2023
* chore: Add a tsconfig.json. * chore: Rename index.js to index.ts * fix: Explicitly declare instance variables. * fix: Implement IPositionable. * fix: Add types to methods. * fix: Add visibility modifiers to methods. * chore: Clean up JSDoc type annotations. * chore: Clean up underscores. * chore: Use template literals where appropriate. * chore: Fix casing of constants. * chore: Format and lint. * chore: Rename test/index.js to test/index.ts * chore: Convert test/index.ts to Typescript * chore: Add TypeScript and corresponding eslint to dev dependencies. * fix: Fix comment casing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes part of #1647 by converting the zoom-to-fit plugin to Typescript.