fix: caller args disconnecting shareable procedures #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
requested review from
rachel-fenichel
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #1893
Proposed Changes
Adds back setting up the argsMap in updateParams.
Reason for Changes
Before if we got any procedure model updates before we got any move events, our argsMap would be empty so all of the our blocks would get disconnected. This makes sure that we at least save the args that are currently attached to the block before doing any reconfiguration.
Test Coverage
Tested the repro steps for #1893 and #1859. Neither reproduces.
Also reconfigured the test pages to make it easier to test a single workspace.
Documentation
N/A
Additional Information
N/A