Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build plugins in esm format #1997

Closed
wants to merge 2 commits into from

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented Sep 30, 2023

The basics

The details

Resolves

Fixes #1877

Proposed Changes

Build index.esm.js in blockly-scripts build

Produces additional files in /dist/

-rw-r--r--  1    8149 Sep 26 23:25 index.esm.js
-rw-r--r--  1   27721 Sep 26 23:25 index.esm.js.map

module field in plugins should be updated to this new file in the future.
This change is non-breaking unless a user includes non-browser (ie node) code, as this was the case for dev-tools repo where it had mocha/sinon code that are being exported..

Reason for Changes

Test Coverage

Tested vite build for plugin-workspace-search. See #1877 for discussion.

Documentation

Additional Information

cc @cpcallen @maribethb

@alicialics alicialics requested a review from a team as a code owner September 30, 2023 22:29
@alicialics alicialics requested review from maribethb and removed request for a team September 30, 2023 22:29
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 30, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@alicialics alicialics changed the title chore: build esm plugins chore: build plugins in esm format Oct 2, 2023
@maribethb
Copy link
Contributor

Hey Zoey, thanks for opening this PR. It kicked off some discussion in the team, but at this time we don't want to introduce a new build tool into our pipeline. It did bring up an interesting idea that we could run webpack twice, one to output esm and one to continue to output minified umd, to meet this need. However this idea still needs more discussion within the team. I'm going to close this PR now, but we do appreciate your thoughts in this space! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import plugin-workspace-search 8.0.4 normally.
2 participants