chore: optimize devsite's toolbox css config and localized names injection #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobyw
changed the title
BeksOmega
requested review from
BeksOmega
and removed request for
rachel-fenichel
BeksOmega
approved these changes
Apr 5, 2024
| // Separator. | ||
| toolboxJson['contents'][6].name = getMsg('Variables'); | ||
| toolboxJson['contents'][7].name = getMsg('Procedures'); | ||
| toolboxJson['contents'].forEach(function (part) { |
There was a problem hiding this comment.
Thanks I think this is a lot better than before!
| @@ -75,31 +75,31 @@ option { | |||
| font-family: var(--font-family) !important; | |||
| } | |||
|
|
|||
| #blockly-0 { | |||
| .blocklyTreeRowLogic { | |||
gonfunko
pushed a commit
to gonfunko/blockly-samples
that referenced
this pull request
Apr 15, 2024
…ction (google#2312) * feat: use css config in devsite toolbox * feat: rename `functions` with `procedures` to correspond to msgs keys * feat: optimize localized string filling approach in devsite * feat: remove colour block style of devsite * chore(format): format with prettier * chore(format): format another file to pass check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
As discussed in #2308, current css config of toolbox config is not that elegant. This PR modifies it by using Category CSS. Also localized string injection is modified to localize by original name (key name) to avoid config one by one.