feat: move backpack to use interface for backpackability #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Apr 6, 2024
|
I also renamed |
BeksOmega
force-pushed
the
feat/backpack-compatibility
branch
from
2cca56f
to
351fa18
Compare
maribethb
approved these changes
Apr 8, 2024
maribethb
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2311
Proposed Changes
Makes it so the backpack uses an interfaces for adding things to itself instead of hard coding to only work with blocks.
Test Coverage
Manually tested that blocks still get added to the backpack.
Documentation
Should be documented somewhere?? Would love opinions! Worst case I'll add it to the dragger docs?
Additional Information
N/A