Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add readme media for plugin fields #2318

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

The details

Resolves

Part of #2216
Part of #2242

Proposed Changes

Copy over gifs and pngs from angle, colour, and multiline input field documenation.

Reason for Changes

Necessary to improve field READMEs. Separating this into a separate PR from the text makes it easier to confirm that links work.

Supersedes https://github.com/google/blockly-samples/pull/2315/files

Documentation

This is part of documentation.

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner April 8, 2024 21:41
@rachel-fenichel rachel-fenichel requested review from BeksOmega and removed request for a team April 8, 2024 21:41
Copy link
Contributor

@BeksOmega BeksOmega Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this one because HALF is readonly now.

@rachel-fenichel rachel-fenichel merged commit 213a977 into google:master Apr 8, 2024
7 checks passed
@rachel-fenichel rachel-fenichel deleted the readme-media branch April 8, 2024 21:57
gonfunko pushed a commit to gonfunko/blockly-samples that referenced this pull request Apr 15, 2024
* chore: add readme media for colour field

* chore: add readme-media for angle field

* chore: add readme-media for multiline input field

* chore: delete unused image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants