fix: scroll-options fixes and compatibility with custom draggables #2358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2354
Proposed Changes
Reason for Changes
bug bash
no more errors when trying to drag bubbles!
Test Coverage
manual testing
Documentation
updated readme
Additional Information
requesting review from beka to make sure my warning about the custom draggable objects seems legit
also, we had discussed offline if using
drag
instead ofmoveDuringDrag
would be sufficient, sincedrag
is already present on hteIDraggable
interface, andmoveDuringDrag
is internal. turns out it works fine!