fix: Hide content highlight on comment drag, update on resize. #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Jul 1, 2024
| @@ -48,7 +48,7 @@ | |||
| "typescript": "^5.4.5" | |||
| }, | |||
| "peerDependencies": { | |||
| "blockly": "^11.0.0" | |||
| "blockly": "^11.1.2" | |||
There was a problem hiding this comment.
This will need another bump before being merged correct?
There was a problem hiding this comment.
I'm not sure. The current release is v11.1.1, so I picked a higher number, but I don't know whether the next release will be a minor or patch release.
There was a problem hiding this comment.
I am also not sure! I don't think we've discussed our next release timeline yet. I'll leave this unresolved for now to make sure we check before releasing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2330
Proposed Changes
Temporarily hides the content highlight when a workspace comment drag is initiated, and reveals it with an updated rectangle when the drag is completed. This is consistent with how block drags are handled.
When a workspace comment resize is completed, the content highlight rectangle is updated. (There's currently no event representing the start of a resize drag, but it's better than nothing.)
Reason for Changes
For consistency with moving regular blocks.
Test Coverage
None.
Documentation
N/A
Additional Information
This PR should not be submitted until the an update is published for the core Blockly library containing: google/blockly#8217