fix: explicitly set the padding on workspace search buttons #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2458
Proposed Changes
Fixes the buttons in the workspace search plugin widget in the Firefox browser by explicitly setting the button padding instead of relying on the user agent styles default.
Before:
After:
Reason for Changes
The padding on the buttons in the workspace search plugin is currently just using the padding specified by the browser's user agent style for buttons. In Chrome, that padding is 6px on the left and right which results in a correctly sized button. Firefox on the other hand has slightly smaller buttons (4px of padding) which results in the error show in the linked issue.
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A