-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser test toolbox_drag_test fails in Drag category because of drag_to_dupe block #8466
Comments
@johnnesky I wanted to work on this issue can you please assign it to me |
Sorry @abhinavjha0239 this isn't open for contributions yet because we're not sure how we want to fix it! |
After discussing with @BeksOmega we think this should be fixed by removing the whole Drag category from the blocks tested by (We should probably write an automated test to do that, too, but that's out of scope for this issue.) |
@abhinavjha0239 Are you still interested in working on this now that we've figured out the desired behavior? |
@BeksOmega yes I am interested in working on it |
Sweet, go for it =) Let me know if you have any questions! |
Description
The
toolbox_drag_test.mjs
file fails when testing the'Drag'
category because it's using the set of blocks defined by thedev-tools
plugin which includes a custom block type calleddrag_to_dupe
which automatically duplicates itself upon being dragged to the workspace, whereas the test is attempting to verify that all blocks in the toolbox add exactly one block to the workspace upon being dragged. Thedrag_to_dupe
block was added in: google/blockly-samples#2377Reproduction steps
npm run test:browser
The text was updated successfully, but these errors were encountered: