Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser test toolbox_drag_test fails in Drag category because of drag_to_dupe block #8466

Closed
johnnesky opened this issue Aug 5, 2024 · 6 comments · Fixed by #8478
Closed
Assignees
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days

Comments

@johnnesky
Copy link
Member

johnnesky commented Aug 5, 2024

Description

The toolbox_drag_test.mjs file fails when testing the 'Drag' category because it's using the set of blocks defined by the dev-tools plugin which includes a custom block type called drag_to_dupe which automatically duplicates itself upon being dragged to the workspace, whereas the test is attempting to verify that all blocks in the toolbox add exactly one block to the workspace upon being dragged. The drag_to_dupe block was added in: google/blockly-samples#2377

Reproduction steps

  1. Run npm run test:browser
  2. The test fails.
@johnnesky johnnesky added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Aug 5, 2024
@abhinavjha0239
Copy link
Contributor

@johnnesky I wanted to work on this issue can you please assign it to me

@BeksOmega
Copy link
Collaborator

Sorry @abhinavjha0239 this isn't open for contributions yet because we're not sure how we want to fix it!

@cpcallen
Copy link
Contributor

cpcallen commented Aug 9, 2024

After discussing with @BeksOmega we think this should be fixed by removing the whole Drag category from the blocks tested by toolbox_drag_test.mjs, since each of the blocks in this category has a separate instruction about how it should be dragged.

(We should probably write an automated test to do that, too, but that's out of scope for this issue.)

@cpcallen cpcallen added help wanted External contributions actively solicited good first issue and removed issue: triage Issues awaiting triage by a Blockly team member labels Aug 9, 2024
@BeksOmega
Copy link
Collaborator

@abhinavjha0239 Are you still interested in working on this now that we've figured out the desired behavior?

@abhinavjha0239
Copy link
Contributor

@BeksOmega yes I am interested in working on it

@BeksOmega
Copy link
Collaborator

Sweet, go for it =) Let me know if you have any questions!

@BeksOmega BeksOmega added size: small Bugs that can be picked up and completed in 1-3 days and removed good first issue labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants