fix: Update dev-tools, remove toolbox category tests Colour and Angles #8457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Aug 5, 2024
|
Created issue to track the remaining drag test failure: #8466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Addresses the issues described in: #8132
Proposed Changes
Updates the dev-tools dependency, and removes references to obsolete toolbox categories
'Colour'and'Angles'.Reason for Changes
dev-tools no longer references obsolete categories, and google/blockly-samples#2346 removed test block categories.
Test Coverage
Previously passing tests still pass. The
toolbox_drag_test.mjsfile innpm run test:browserwas failing previously and is still failing, but less badly. In particular, the'Drag'test toolbox category is still failing even after my changes, because google/blockly-samples#2377 added a test block to this category called'drag_to_dupe'that duplicates itself after dragging, which results in the workspace containing two top-level blocks after the drag, and thetoolbox_drag_test.mjstest tries to validate that there's only one top block in the workspace after each drag.