Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bumping copied objects #7349

Merged

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Aug 1, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A

Proposed Changes

Adds logic to bump pasted blocks out of the way of other blocks.
Adds logic to bump pasted comments out of the way of their original comment.

Reason for Changes

Pasting blocks directly on top of other blocks or within the snap radius of other connections is confusing to the end user.

Test Coverage

Added a test to make sure block create events are being fired.
Added tests to make sure the bumping is working correctly.

Documentation

N/A

Additional Information

Dependent on #7348

@BeksOmega BeksOmega requested a review from a team as a code owner August 1, 2023 22:33
@github-actions github-actions bot added the PR: fix Fixes a bug label Aug 1, 2023
@BeksOmega BeksOmega marked this pull request as draft August 1, 2023 22:42
@BeksOmega BeksOmega force-pushed the fix/bumping-copied-objects branch 2 times, most recently from 2ab0458 to a72ac76 Compare August 2, 2023 20:58
@BeksOmega BeksOmega changed the base branch from develop to operation-copy-that August 4, 2023 17:49
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Aug 4, 2023
@BeksOmega BeksOmega marked this pull request as ready for review August 4, 2023 17:51
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Aug 4, 2023
@BeksOmega
Copy link
Collaborator Author

@NeilFraser This is ready for review =)

@BeksOmega BeksOmega merged commit a901c62 into google:operation-copy-that Aug 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants