Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove the old block factory. #7358

Closed
wants to merge 1 commit into from
Closed

chore: Remove the old block factory. #7358

wants to merge 1 commit into from

Conversation

gonfunko
Copy link
Contributor

@gonfunko gonfunko commented Aug 4, 2023

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

This PR removes the old block factory code.

@gonfunko gonfunko requested a review from a team as a code owner August 4, 2023 16:36
@gonfunko gonfunko requested a review from BeksOmega August 4, 2023 16:36
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Aug 4, 2023
@gonfunko
Copy link
Contributor Author

gonfunko commented Aug 4, 2023

Turns out we are still linking to/using this, withdrawing this PR accordingly.

@gonfunko gonfunko closed this Aug 4, 2023
@gonfunko gonfunko deleted the unblockfactory branch August 4, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega Awaiting requested review from BeksOmega BeksOmega is a code owner automatically assigned from google/blockly-eng

Assignees

@BeksOmega BeksOmega

Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonfunko @BeksOmega