-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests): Introduce loading shims, use in playgrounds #7380
Merged
Commits on Aug 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8bb6ac5 - Browse repository at this point
Copy the full SHA 8bb6ac5View commit details -
fix(closure): Make safe to import in node.js
Make the implementation declareModlueId safe to import and execute in node.js, which does not provide a window global. (N.B. because this is an ESM and therefore automatically strict, using window?.goog?.declareModuleId doesn't work because window being undefined is an early error.)
Configuration menu - View commit details
-
Copy full SHA for cf460dc - Browse repository at this point
Copy the full SHA cf460dcView commit details -
feat(tests): Introduce chunk loading shims
- Add a buildShims task to build_tasks.js that, for each chunk, creates a correspondingly-named build/<chunk>.mjs that will either (in uncompressed mode) import and reexport that chunk's entry point module (e.g. core/blockly.js) or (in compressed mode) load dist/<chunk>_compressed.js using a <script> tag and then export the corresponding properties on the chunk's exports object. - Provide helper methods used by these shims in tests/scripts/loading.mjs, including code to detect whether to load in compressed or uncompressed mode. - Add a quote() function to scripts/helpers.js, used by buildShims. This is copied from tests/bootstrap_helper.js, which will be removed in a later commit.
Configuration menu - View commit details
-
Copy full SHA for 64b531b - Browse repository at this point
Copy the full SHA 64b531bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2883d16 - Browse repository at this point
Copy the full SHA 2883d16View commit details -
Configuration menu - View commit details
-
Copy full SHA for a25b2ed - Browse repository at this point
Copy the full SHA a25b2edView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc5f42b - Browse repository at this point
Copy the full SHA dc5f42bView commit details -
chore(tests): Delete playgrounds/shared_procedures.html
Shared procedure support was moved to a plugin and this should have been removed from core along with it.
Configuration menu - View commit details
-
Copy full SHA for 653e12f - Browse repository at this point
Copy the full SHA 653e12fView commit details
Commits on Aug 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2e6b6f6 - Browse repository at this point
Copy the full SHA 2e6b6f6View commit details -
chore(tests): Add ".loader" infix to shim filenames.
Per suggestion on PR google#7380, have buildShims name the shims ${chunk.name}.loader.mjs instead of just `${chunk.name}.mjs`.
Configuration menu - View commit details
-
Copy full SHA for 6f930f5 - Browse repository at this point
Copy the full SHA 6f930f5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.