chore: Use JSON objects for context menu callbackFactory #7382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #5579
Proposed Changes
Adds support for using JSON objects to define blocks to be instantiated by callbackFactory(...) for context menus, while preserving support for using XML. Ports existing usage of callbackFactory(...) in core from XML to JSON objects.
Behavior Before Change
Only XML is supported for the second argument of callbackFactory(...).
Behavior After Change
Both XML and JSON objects are supported for the second argument.
Reason for Changes
XML support is deprecated.
Test Coverage
Documentation
The automatic documentation will need to be updated at: https://developers.google.com/blockly/reference/js/blockly.contextmenu_namespace