Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make generator quoting methods public #7392

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Aug 14, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Work on #7326

Proposed Changes

Makes the quote_ and multiline_quote_ methods public.

Reason for Changes

quote_ and multiline_quote_ were previously inaccessible to external developers. They can now be accessed inside block-code generators just like they are in core.

Test Coverage

N/A

Documentation

This is for some documentation :D

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner August 14, 2023 17:16
@github-actions github-actions bot added the PR: feature Adds a feature label Aug 14, 2023
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/generator.ts Outdated Show resolved Hide resolved
core/generator.ts Outdated Show resolved Hide resolved
core/generator.ts Outdated Show resolved Hide resolved
@BeksOmega
Copy link
Collaborator Author

BeksOmega commented Aug 15, 2023

@cpcallen This is ready for rereview =)

[Edit: nvm, needs edits in response to https://github.com//issues/7326#issuecomment-1681298070 ]

@rachel-fenichel
Copy link
Collaborator

Makes CodeGenerator abstract.

It looks like this is no longer true, so please remove from the description before merging.

@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Aug 21, 2023
@BeksOmega BeksOmega merged commit a0301a2 into google:develop Aug 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants