Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: insertion marker's next blocks are real blocks" #7429

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Revert "fix: insertion marker's next blocks are real blocks" #7429

merged 1 commit into from
Aug 24, 2023

Conversation

rachel-fenichel
Copy link
Collaborator

Reverts #7384

See google/blockly-samples#1856 (comment) for context on why we are rolling back the change to make insertion markers use JSON serialization.

Full steps:

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner August 24, 2023 17:37
@rachel-fenichel rachel-fenichel merged commit 9db853d into develop Aug 24, 2023
14 checks passed
@rachel-fenichel rachel-fenichel deleted the revert-7384-develop branch August 24, 2023 17:41
@rachel-fenichel rachel-fenichel mentioned this pull request Aug 24, 2023
Merged
rachel-fenichel added a commit that referenced this pull request Aug 24, 2023
@rachel-fenichel
Revert "fix: insertion marker's next blocks become real block (#7384)" (
316571a 
#7429)

This reverts commit 18ee0ec.

(cherry picked from commit 9db853d)
@rachel-fenichel rachel-fenichel mentioned this pull request Aug 24, 2023
Merged
@BeksOmega BeksOmega mentioned this pull request Dec 19, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachel-fenichel @BeksOmega