Added blocklyImageField CSS class to image fields #8439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @BeksOmega I have got all requirements please check my pr |
BeksOmega
requested review from
BeksOmega
and removed request for
rachel-fenichel
BeksOmega
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue -> #8314
fixes #8314
Description :
This pull request introduces a change to the
FieldImageclass in Blockly to enhance the styling capabilities of image fields. By adding theblocklyImageFieldCSS class to thefieldGroup_element, developers can now apply custom styles more easily to image fields within Blockly.Changes Made :
initViewmethod incore/field_image.tsto calldom.addClasswiththis.fieldGroup_and'blocklyImageField'.Details:
The
initViewmethod has been updated to ensure that theblocklyImageFieldCSS class is applied to thefieldGroup_element whenever an image field is initialized. This addition enhances the flexibility for developers to customize the appearance of image fields using CSS.Branch :
rc/v12.0.0branch.By adding the
blocklyImageFieldclass, developers can now easily apply CSS styles specific to image fields, enhancing the visual customization options available in Blockly.