fix!: Renamed the blocklyTreeSelected CSS class to blocklyToolboxSelected #8459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpcallen @BeksOmega Please review this PR |
|
Thanks @BeksOmega |
BeksOmega
changed the title
github-actions
bot
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue -> #8351
fixes #8351
Description
This pull request updates the CSS class names associated with the selection state of toolbox categories in Blockly. The changes improve clarity and consistency by aligning the CSS class naming with the context in which they are used.
Changes Made
Renamed CSS Classes: Updated the CSS class name from
blocklyTreeSelectedtoblocklyToolboxSelectedacross the relevant files. This change reflects the role of the class in styling the selected state of toolbox categories rather than tree elements.CSS Style Updates: Adjusted the CSS selectors to use the new class name, ensuring that all styling for selected toolbox categories remains functional.
Motivation
The renaming of CSS classes enhances code readability and maintainability by making it clear which elements are being targeted for styling. It eliminates ambiguity and aligns with the conventions used throughout the codebase for naming CSS classes associated with toolbox components.