-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement WorkspaceSvg
class manipulation
#8473
feat: implement WorkspaceSvg
class manipulation
#8473
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
…' into workspace-svg-class-manipulation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just two little docs fixes then I can get this merged =)
Co-authored-by: Beka Westberg <[email protected]>
Co-authored-by: Beka Westberg <[email protected]>
I accepted both of those. Sorry about those commit names- I didn't notice that it was using the default name when accepting the suggestion. |
No worries at all! Thank you for your work on this =) |
The basics
The details
Resolves
Fixes #8281
Proposed Changes
Implements
addClass
andremoveClass
methods to theWorkspaceSvg
class.Reason for Changes
As requested in #8281
Test Coverage
Ran the usual build/test scripts and also made sure it worked okay in the playground.
Documentation
Yes, add docs for the new methods
Additional Information