feat: Add a BlockFlyoutInflater class. #8591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested changes
Sep 27, 2024
core/block_flyout_inflater.ts
Outdated
| private capacityFilter: (e: AbstractEvent) => void; | ||
|
|
||
| constructor() { | ||
| this.capacityFilter = (event: AbstractEvent) => { |
There was a problem hiding this comment.
Why is the capacity filter defined in the constructor instead of just another method?
There was a problem hiding this comment.
Because we need this bound, but updated it to use the wrapper pattern used elsewhere thoughout the codebase.
rachel-fenichel
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8541 and fixes #8542.
Proposed Changes
This PR adds a concrete implementation of IFlyoutInflater responsible for creating blocks in the flyout. It also includes the existing capacity filtering logic. Because recycling is not used in core, recycling support is not included; it will be added in a subclass in the continuous toolbox plugin.