feat: Add support for inflating flyout separators. #8592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
requested review from
cpcallen and
rachel-fenichel
and removed request for
cpcallen
rachel-fenichel
requested changes
Sep 27, 2024
| private y = 0; | ||
| constructor(private gap: number) {} | ||
|
|
||
| getBoundingRectangle(): Rect { |
There was a problem hiding this comment.
If someone uses a really big gap value in a vertical flyout, can it cause the flyout to become excessively wide as a result of the gap being a square instead of a rectangle? If yes, I think we should have gapX and gapY be specified separately
There was a problem hiding this comment.
Yes; updated it to take an axis argument and be zero-width on the non-dominant axis.
rachel-fenichel
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR adds a new
FlyoutSeparatorclass to represent a gap between items in a flyout, and a corresponding flyout inflater for items of this type. This will allow flyouts to no longer have to track gaps and content in separate lists, and instead just use one list of content items, some of which are rendered blocks/buttons/labels/etc and some of which are invisible spacers that simply occupy space between other items.