fix: Fix bug that caused fields in the flyout to use the main workspace's scale. #8607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8596
Proposed Changes
This PR introduces a new
WorkspaceSvg.getAbsoluteScale()method that returns the absolute scale of a workspace, taking into account whether it is in a flyout, nested in one or more parent workspaces, mutator editors, etc. Workspace scaling is somewhat counterintuitive in that workspaces that are children of one another have multiplicative scaling, because scaling is achieved through transforms and those apply to child elements and compound.The PR also updates field editors, which are visually associated with a particular workspace but live at the top of the DOM, to use the absolute scale of their visually-associated workspace.