Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix exception when disposing of a workspace with a variable block obscuring a shadow block. #8619

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: Fix exception when disposing of a workspace with a variable block obscuring a shadow block. #8619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,14 @@ export class Workspace implements IASTNodeLocation {
this.topComments[this.topComments.length - 1].dispose();
}
eventUtils.setGroup(existingGroup);
this.variableMap.clear();
// If this is a flyout workspace, its variable map is shared with the
// parent workspace, so we either don't want to disturb it if we're just
// disposing the flyout, or if the flyout is being disposed because the
// main workspace is being disposed, then the main workspace will handle
// cleaning it up.
if (!this.isFlyout) {
this.variableMap.clear();
}
if (this.potentialVariableMap) {
this.potentialVariableMap.clear();
}
Expand Down
Loading