Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recompression #824
base: recompression
Are you sure you want to change the base?
Recompression #824
Changes from 12 commits
1073576
2b23df6
78e60c6
3219988
e7f7a6c
2c1aaf9
3b7288f
c2369f7
bbbecc1
51ccb89
75b92f5
a0d3169
1f224d1
85da9f6
f1f207b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using this ALLOC function instead of malloc elsewhere? If so, maybe add a TODO to make sure this happens as part of productization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Everything inside decoder/encoder should allocate/free memory via macros to allow "custom memory manager" feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inside Encoder/Decoder I'm using Brotli allocation, malloc is used only in testing and in compress_similar_files.h file as they are not a part of the library. However, when compress_similar_files.h will be a part of the library then Brotli macros should be used