This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Take picture crash fix #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }); | ||
| try { | ||
| mCamera.takePicture(null, null, null, new Camera.PictureCallback() { |
There was a problem hiding this comment.
How about to move this callback instantiation to outside of the try/catch?
There was a problem hiding this comment.
Thanks for your suggestion. Could you please specify what kind of effect will this change have?
|
It seems to me that this is simply ignoring the error rather than fixing it. |
|
@yaraki Agree. But it crashes in native method without any explanation about the cause. Is it possible to somehow detect the cause? |
ewolfox
pushed a commit
to ewolfox/cameraview
that referenced
this pull request
Apr 13, 2018
|
Did this ever get fixed? At least partially? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for my #96. I got exception every time when moved phone and took picture in the same time(as described in #96). Exception isn't verbose enough and doesn't explain the cause of exception which is originally thrown from internal native code. So to avoid app crash we can catch exception when calling
mCamera.takePicture(...).After adding this
try-catchblock we still get same exception and log it, but app doesn't crash and picture is actually taken.