This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Preview callback #174
Open
doug-precocity
wants to merge
6
commits into
google:master
Choose a base branch
from
doug-precocity:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Preview callback #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previewCallback receives an Image object, consistent with the Camera2 API. Packed/interleaved Camera1 image formats are stored on a single Plane. The preferred format can be specified. If available that format will be used, and if not, will fall back to whatever the default format is.
This reverts commit ca68dc3.
The preview callback receives an Image object, consistent with the Camera2 API. Packed/interleaved Camera1 image formats are stored on a single Plane in the Image. The preferred format for the preview can be specified. If available, that format will be used and if not, will fallback to whatever the default format is.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
-fix error where callback sill called after releasing camera -downloaded dependency jars and removed references to mavencentral and jcenter
Conflicts: library/src/main/api14/com/google/android/cameraview/Camera1.java
ewolfox
pushed a commit
to ewolfox/cameraview
that referenced
this pull request
Apr 13, 2018
* Add VideoCodec options * Fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preview callback accepts a byte array. If the image has multiple planes, all the planes of the image are concatenated sequentially. The preferred preview image format can be specified in XML or Java.