Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

complete miss comment #262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

complete miss comment #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4acd79
comment complete
LeonChen1024 Dec 4, 2018
c15159c
fix green preview bug
LeonChen1024 Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/main/base/com/google/android/cameraview/AspectRatio.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class AspectRatio implements Comparable<AspectRatio>, Parcelable {

/**
* Returns an instance of {@link AspectRatio} specified by {@code x} and {@code y} values.
* The values {@code x} and {@code} will be reduced by their greatest common divider.
* The values {@code x} and {@code y} will be reduced by their greatest common divider.
*
* @param x The width
* @param y The height
Expand Down
4 changes: 3 additions & 1 deletion library/src/main/java/com/google/android/cameraview/CameraView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,10 @@ private PreviewImpl createPreviewImpl(Context context) {
PreviewImpl preview;
if (Build.VERSION.SDK_INT < 14) {
preview = new SurfaceViewPreview(context, this);
} else {
} else if (Build.VERSION.SDK_INT < 24){
preview = new TextureViewPreview(context, this);
}else {
preview = new SurfaceViewPreview(context, this);
}
return preview;
}
Expand Down