Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Add a getter to get the camera orientation relative to the devices native orientation #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matt-oakes
Copy link

This is useful for when you are using the image data from the onFramePreview callback and need to correct the image rotation before sending it through to something like the Mobile Vision SDK.

The lack of this was causing libraries to make assumptions about the camera orientation which causes bugs like this: react-native-camera/react-native-camera#1714

Copy link

@sibelius sibelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

However this project has been stale, so we have a copy of it inside react native camera that you could contribute back

@matt-oakes
Copy link
Author

I realised that just after I made this. I've opened a PR over there including both parts react-native-camera/react-native-camera#2050

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants