Update strings.format to adhere to the specification #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
| @@ -186,6 +186,10 @@ func (s String) Value() any { | |||
| return string(s) | |||
| } | |||
|
|
|||
| func (s String) String() string { | |||
| return strconv.Quote(string(s)) | |||
There was a problem hiding this comment.
I feel like we should leave this one alone and maybe use %q in places where we print the string like in lists and maps. Seems less likely to hit a change-detector test issue that way too.
There was a problem hiding this comment.
Unfortunately we cannot use %q because that would quote everything, including ints. We pass ref.Value to %s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.