Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy immarg attribute in LowerAddrSpaceCast #1351

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Do not copy immarg attribute in LowerAddrSpaceCast #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/LowerAddrSpaceCastPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,12 @@ llvm::Value *clspv::LowerAddrSpaceCastPass::visitCallInst(llvm::CallInst &I) {
};
Function *EquivalentFunction = getEquivalentFunction();
EquivalentFunction->copyAttributesFrom(F);

// When creating intrinsics equivalents (eg. llvm.memcpy.*), we must drop
// attributes that cannot be applied to non-intrinsics.
for (auto i = 0u; i < EquivalentFunction->arg_size(); ++i) {
EquivalentFunction->removeParamAttr(i, Attribute::ImmArg);
}
EquivalentFunction->setCallingConv(F->getCallingConv());

IRBuilder<> B(&I);
Expand Down
23 changes: 23 additions & 0 deletions test/AddressSpaceCast/issue-1350.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
; RUN: clspv-opt %s -o %t.ll --passes=lower-addrspacecast
; RUN: FileCheck %s < %t.ll

; CHECK: declare void @_Z21llvm.memcpy.p0.p4.i32PPU3AS1memcpy.p0.p4.i32(ptr noalias nocapture writeonly, ptr addrspace(1) noalias nocapture readonly, i32, i1) #0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is clspv really able to deal with such a function to emit anything valid?
Maybe because it contains llvm.memcpy it works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the replace intrinsics pass seems prepared for this, as it looks at the function name containing "llvm.memcpy".


; CHECK-NOT: addrspacecast
; CHECK-NOT: @llvm.memcpy.p0.p4.i32

target datalayout = "e-p:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024"
target triple = "spir-unknown-unknown"

define dso_local spir_kernel void @kern(ptr addrspace(1) align 4 %in) {
entry:
%cpy = alloca [4 x float], align 4
%0 = addrspacecast ptr addrspace(1) %in to ptr addrspace(4)
call void @llvm.memcpy.p0.p4.i32(ptr align 4 %cpy, ptr addrspace(4) align 4 %0, i32 16, i1 false)
ret void
}

; Function Attrs: nocallback nofree nounwind willreturn memory(argmem: readwrite)
declare void @llvm.memcpy.p0.p4.i32(ptr noalias nocapture writeonly, ptr addrspace(4) noalias nocapture readonly, i32, i1 immarg) #0

attributes #0 = { nocallback nofree nounwind willreturn memory(argmem: readwrite) }