Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new fuzz targets in split builds properly #4436

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Handle new fuzz targets in split builds properly #4436

merged 2 commits into from
Nov 26, 2024

Conversation

jonathanmetzman
Copy link
Collaborator

Previously we tried to handle it by finding the fuzz targets in the list. But we still failed because it wasn't in the db. Save it to the db to solve this problem.

Previously we tried to handle it by finding the fuzz targets
in the list. But we still failed because it wasn't in the db.
Save it to the db to solve this problem.
@jonathanmetzman
Copy link
Collaborator Author

CC @marktefftech

Copy link
Collaborator

@marktefftech marktefftech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming binary=fuzz_target_binary, will pickup the binaries in the FUZZ_TARGET_BUILD_BUCKET location, this LGTM.

@jonathanmetzman jonathanmetzman merged commit 933a999 into master Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants