Support multiple regions in batch #4453
Merged
+47
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation Cumulative distribution metrics from the monitoring initiative were incorrectly set to use the fixed width bucketer, and/or width=0.05 and max_buckets=20. This caused percentile metrics to cap at 1, which was wrong behavior. This PR attempts to fix that by moving them all to Geometric Bucketer, without the aforementioned limits. It also reverts #4429 , since it apparently broke triage.py in chrome. Part of #4271
Fetching the testcase from the datastore has been wrongly moved before the call to `_update_testcase`. This leads to us holding an outdated version of the testcase.
…4437) Some parts of CF will chdir, breaking relative paths.
### Motivation Chrome folks want to know what build revision is being used in fuzz task. This PR implements that.
1. Don't unnecessarily list features about blobs other than names 2. Memoize leak blacklist stuff. 3. Properly skip cleanup.
Previously we tried to handle it by finding the fuzz targets in the list. But we still failed because it wasn't in the db. Save it to the db to solve this problem.
Getting credentials is pretty slow since it launches a gcloud process. We should just cache credentials. Supposedly the library itself handles refreshes. We are also caching in storage.py so there's proof it's safe.
We want tworkers to skip the function, not non-tworkers.
It's important for speed, probably safe on tworkers, and it will be very easy to notice if things go wrong since the preprocess queue will pile up. This PR also fixes a bad bug where the max_pool_size was not obeyed, but in practice since this code never runs on machines with more than 2 cores, it's unlikely to matter. Partial undoes #4430
|
Supersedes #4399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use randomness to "load balance" for now.