-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vi: Day 1 Morning - Types and Values translation #2020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks LGMT! Does this need any changes @daivinhtran
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khoaxuantu can you try running the mdbook again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Vinh that you'd better provide translation for the base case and recursive case.
Okay! I will change it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good rn. Do you still have problems running mdbook for the first two lines of the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khoaxuantu For now, please lemme try running mdbook on my machine locally.
Hi @khoaxuantu, can you rebase this PR and resolve the conflicts? @qu-ngx, can we merge this afterwards? |
If I read the comments correctly, the state was good three months ago
I looked at the conflict and it was tiny, so I resolved it. I also removed the changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the discussion, I believe this is good to merge.
This bumped Vietnamese up a lot in https://google.github.io/comprehensive-rust/translation-report.html 🎉 Before there were 480 translated strings, now there will be 547 based on running the report locally. |
@mgeisler I couldn't respond immediately when you mentioned me because of my on-going working hours. The PR was pending before due to a few conflicts in the Now, I see that it has been resolved in another PR, so it is good to merge then. Thank you for having resolved it for me 🙇 |
No worries at all, I understand that reviewing these PRs is hard and tedious work. They often end up getting stale because of small conflicts here and there, so that is why I tried to push it over the finishing line 😄 I just hope I don't make a mess out of it, since I cannot read anything in the PRs.
Thanks for confirming, I'm glad I could help! |
By the way, see #1948 (comment) for a multi-step procedure to hand-merging out of date |
Here is the translation of Day 1 Morning: Type and Values translation.
It seems like there is no corresponding definition of hygienic macros in Vietnamese, so I think keeping its English word is fine.